feat: add ColorCorrection protobuf messages#263
Merged
Merged
Conversation
Add control/telemetry messages to enable/disable and set the intensity of the X3 Ultra underwater color-correction filter (beuwcolor). intensity (0-1) scales the correction toward identity. Reuses FilterMessage, mirroring the turbidity filter messages.
jp-pino
changed the title
jp-pino
marked this pull request as ready for review
July 7, 2026 13:52
Contributor
There was a problem hiding this comment.
Pull request overview
Adds new protobuf control/telemetry messages to expose the X3 Ultra underwater color-correction filter (beuwcolor) using the shared FilterMessage (enabled + intensity 0..1) format.
Changes:
- Add
ColorCorrectionTeltelemetry message carryingFilterMessagefor color-correction settings. - Add
SetColorCorrectionCtrlcontrol message carryingFilterMessageto set color-correction intensity/enabled state. - Expand
SetTurbidityFilterCtrlcomments to document CLAHE usage and X3 Ultra support.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| protobuf_definitions/telemetry.proto | Adds ColorCorrectionTel telemetry message using FilterMessage. |
| protobuf_definitions/control.proto | Adds SetColorCorrectionCtrl and documents X3 Ultra filter controls (incl. turbidity). |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
SetColorCorrectionCtrlandColorCorrectionTelprotobuf messages for the X3 Ultra underwater color-correction filter (beuwcolor).Uses the shared
FilterMessageformat (enabled + intensity, where intensity 0–1 scales the correction toward identity).Related PRs: